FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
50 12 0 0

Files

Class Bugs
org.sim0mq.federatestarter.FederateStarter 3
org.sim0mq.message.Sim0MQMessage$Builder 2
org.sim0mq.message.SimulationMessage 4
org.sim0mq.message.federationmanager.FM2SimRunControlMessage 3

org.sim0mq.federatestarter.FederateStarter

Bug Category Details Line Priority
Found reliance on default encoding in org.sim0mq.federatestarter.FederateStarter.processKillFederate(String, Object[]): String.getBytes() I18N DM_DEFAULT_ENCODING 443 High
Found reliance on default encoding in org.sim0mq.federatestarter.FederateStarter.waitForModelStarted(Object, String, int): String.getBytes() I18N DM_DEFAULT_ENCODING 353 High
Exceptional return value of java.io.File.delete() ignored in org.sim0mq.federatestarter.FederateStarter.processKillFederate(String, Object[]) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 479 Medium

org.sim0mq.message.Sim0MQMessage$Builder

Bug Category Details Line Priority
Unread public/protected field: org.sim0mq.message.Sim0MQMessage$Builder.messageStatus STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 332 Medium
Unread public/protected field: org.sim0mq.message.Sim0MQMessage$Builder.messageTypeId STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 310 Medium

org.sim0mq.message.SimulationMessage

Bug Category Details Line Priority
org.sim0mq.message.SimulationMessage.encode(Encoding, Object, Object, Object, Object, long, MessageStatus, Object[]) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 75 Medium
org.sim0mq.message.SimulationMessage.encode(Encoding, Object, Object, Object, Object, long, MessageStatus, Object[]) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 76 Medium
org.sim0mq.message.SimulationMessage.encodeReply(Encoding, String, Object, Object, Object, Object, long, MessageStatus, Object[]) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 119 Medium
org.sim0mq.message.SimulationMessage.encodeReply(Encoding, String, Object, Object, Object, Object, long, MessageStatus, Object[]) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 120 Medium

org.sim0mq.message.federationmanager.FM2SimRunControlMessage

Bug Category Details Line Priority
Boxed value is unboxed and then immediately reboxed in org.sim0mq.message.federationmanager.FM2SimRunControlMessage.createMessage(Object[], Object) PERFORMANCE BX_UNBOXING_IMMEDIATELY_REBOXED 298 Medium
org.sim0mq.message.federationmanager.FM2SimRunControlMessage.createByteArray() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 276 Medium
org.sim0mq.message.federationmanager.FM2SimRunControlMessage.createObjectArray() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 256 Medium