FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
30 14 0 0

Files

Class Bugs
org.sim0mq.federatestarter.FederateStarter 3
org.sim0mq.message.Sim0MQMessage$Builder 2
org.sim0mq.message.Sim0MQReply$Builder 1
org.sim0mq.message.SimulationMessage 4
org.sim0mq.message.federationmanager.SimRunControlMessage 1
org.sim0mq.message.types.Sim0MQDisplayType 2
org.sim0mq.message.types.Sim0MQUnitType 1

org.sim0mq.federatestarter.FederateStarter

Bug Category Details Line Priority
Found reliance on default encoding in org.sim0mq.federatestarter.FederateStarter.processKillFederate(String, Object[]): String.getBytes() I18N DM_DEFAULT_ENCODING 411 High
Found reliance on default encoding in org.sim0mq.federatestarter.FederateStarter.waitForModelStarted(Object, String, int): String.getBytes() I18N DM_DEFAULT_ENCODING 323 High
Exceptional return value of java.io.File.delete() ignored in org.sim0mq.federatestarter.FederateStarter.processKillFederate(String, Object[]) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 447 Medium

org.sim0mq.message.Sim0MQMessage$Builder

Bug Category Details Line Priority
Unread public/protected field: org.sim0mq.message.Sim0MQMessage$Builder.messageStatus STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 312 Medium
Unread public/protected field: org.sim0mq.message.Sim0MQMessage$Builder.messageTypeId STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 290 Medium

org.sim0mq.message.Sim0MQReply$Builder

Bug Category Details Line Priority
Unread public/protected field: org.sim0mq.message.Sim0MQReply$Builder.replyToId STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 89 Medium

org.sim0mq.message.SimulationMessage

Bug Category Details Line Priority
org.sim0mq.message.SimulationMessage.encode(Encoding, Object, Object, Object, Object, long, MessageStatus, Object[]) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 72 Medium
org.sim0mq.message.SimulationMessage.encode(Encoding, Object, Object, Object, Object, long, MessageStatus, Object[]) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 73 Medium
org.sim0mq.message.SimulationMessage.encodeReply(Encoding, String, Object, Object, Object, Object, long, MessageStatus, Object[]) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 115 Medium
org.sim0mq.message.SimulationMessage.encodeReply(Encoding, String, Object, Object, Object, Object, long, MessageStatus, Object[]) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 116 Medium

org.sim0mq.message.federationmanager.SimRunControlMessage

Bug Category Details Line Priority
Boxed value is unboxed and then immediately reboxed in org.sim0mq.message.federationmanager.SimRunControlMessage.createMessage(Object[], Object) PERFORMANCE BX_UNBOXING_IMMEDIATELY_REBOXED 262 Medium

org.sim0mq.message.types.Sim0MQDisplayType

Bug Category Details Line Priority
Possible null pointer dereference of null in org.sim0mq.message.types.Sim0MQDisplayType.getByteCode(Unit) CORRECTNESS NP_NULL_ON_SOME_PATH 2495 High
Possible null pointer dereference of null in org.sim0mq.message.types.Sim0MQDisplayType.getIntCode(Unit) CORRECTNESS NP_NULL_ON_SOME_PATH 2482 High

org.sim0mq.message.types.Sim0MQUnitType

Bug Category Details Line Priority
Possible null pointer dereference of null in org.sim0mq.message.types.Sim0MQUnitType.getUnitCode(Unit) CORRECTNESS NP_NULL_ON_SOME_PATH 278 High